Add cardtype to org/user level project on creation, edit and view #24043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
topic/ui
silverwind
approved these changes
Apr 11, 2023
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #24043 +/- ##
==========================================
- Coverage 47.14% 46.98% -0.17%
==========================================
Files 1149 1163 +14
Lines 151446 153673 +2227
==========================================
+ Hits 71397 72196 +799
- Misses 71611 72978 +1367
- Partials 8438 8499 +61
... and 127 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
approved these changes
Apr 11, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
I was unable to create a backport for 1.19. @HesterG, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 12, 2023
* upstream/main: Add popup to hashed comments/pull requests/issues in file editing/adding preview tab (go-gitea#24040) Use reactive store to share data between components (go-gitea#23996) [skip ci] Updated translations via Crowdin Fix accidental overwriting of LDAP team memberships (go-gitea#24050) Add cardtype to org/user level project on creation, edit and view (go-gitea#24043) Fix branch protection priority (go-gitea#24045) Update documentation to explain which projects allow Gitea to host static pages (go-gitea#23993) Fix date display bug (go-gitea#24047) Fine tune markdown editor toolbar (go-gitea#24046) Add tooltips for MD editor buttons and add `muted` class for buttons (go-gitea#23896) Prefer native parser for SSH public key parsing (go-gitea#23798)
silverwind
added a commit
that referenced
this pull request
Apr 12, 2023
…4043) (#24066) Backport #24043 Part of #23318 The way to fix the missing cardtype for user/org level projects in this PR is to port the cardtype related part from #22112 to org/user level projects' template and router functions. Before: <img width="1135" alt="截屏2023-04-11 13 55 49" src="https://user-images.githubusercontent.com/17645053/231069068-ba897129-ae90-4aa0-9b0f-468bf5c65375.png"> <img width="1131" alt="截屏2023-04-11 13 55 59" src="https://user-images.githubusercontent.com/17645053/231069084-279f6681-5a10-42da-b5a8-2b0ba47c7078.png"> After: Create <img width="835" alt="截屏2023-04-11 13 27 16" src="https://user-images.githubusercontent.com/17645053/231064445-0d6e12bd-5725-48db-a102-80e7472757c2.png"> Edit <img width="852" alt="截屏2023-04-11 13 27 05" src="https://user-images.githubusercontent.com/17645053/231064503-c70525cd-1038-43ec-8d93-8b8d95d183d4.png"> View <img width="1329" alt="截屏2023-04-11 13 26 56" src="https://user-images.githubusercontent.com/17645053/231064529-26023c85-698b-4b2e-af02-45f9820c77ec.png"> --------- Co-authored-by: silverwind <me@silverwind.io>
|
We lock pull requests 3 months after they were closed. If there's any need for further discussion, please open a new issue. 🍵 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #23318
The way to fix the missing cardtype for user/org level projects in this PR is to port the cardtype related part from #22112 to org/user level projects' template and router functions.
Before:
After:
Create
Edit
View
